Move check for plus usage endpoint to test-with-plus target (#2902) (#2904)#2908
Merged
Merged
Conversation
github-actions
Bot
added
chore
sjberman
approved these changes
Dec 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.5 #2908 +/- ##
============================================
Coverage 89.71% 89.71%
============================================
Files 109 109
Lines 11091 11091
Branches 50 50
============================================
Hits 9950 9950
Misses 1082 1082
Partials 59 59 ☔ View full report in Codecov by Sentry. |
kate-osborn
force-pushed
the
chore/cherry-pick-check-for-plus-fix
branch
from
555f943 to
b788a6d
Compare
bjee19
approved these changes
Dec 13, 2024
Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set. Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.
Problem: #2902 moved check-for-plus-usage-endpoint dependency to the wrong Makefile target which caused the pipelines on main to fail. Solution: Move check-for-plus-usage-endpoint` dependency to the right target.
kate-osborn
force-pushed
the
chore/cherry-pick-check-for-plus-fix
branch
from
b788a6d to
160d35b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2902 and #2904 into release-1.5. I'm combining the commits because the first one was an incomplete fix.
Problem: Functional tests for OSS on forks are failing because the PLUS_USAGE_ENDPOINT isn't set.
Solution: Move check for PLUS_USAGE_ENDPOINT to the test-with-plus target.